Conversation
jordanxwu
commented
Feb 13, 2026
jordanxwu
commented
- created carousel component
| } | ||
| } | ||
|
|
||
| @keyframes spin { |
There was a problem hiding this comment.
i think for scrollable carousel they meant like you can just horizontally scroll it with your scroll wheel, this is nice but it doesn't work well when a component is this large
| } | ||
| } | ||
|
|
||
| .projectCard { |
There was a problem hiding this comment.
this is just a organization thing but i think it would've been nicer if you nested projectCard childrens' styling within .projectCard like how u did it in .cardLabel
There was a problem hiding this comment.
also the background color for the blue part of these is a gradient
| button{ | ||
| // button | ||
| display: flex; | ||
| width: 14.0625rem; |
There was a problem hiding this comment.
don't set button width and heights, typically for things liek this use padding
There was a problem hiding this comment.
you also have a lot of extra styling here like flex that you don't need
| @@ -0,0 +1,126 @@ | |||
| .PastMissions { | |||
There was a problem hiding this comment.
im assuming this is like the main container, why isn't the 6.25rem padding set here instead of in the title and cards individually
| display: flex; | ||
| flex-direction: column; | ||
| align-items: flex-start; | ||
| gap: 2rem; |
There was a problem hiding this comment.
2rem is the incorrect amount
| } | ||
|
|
||
| .cardLabel { | ||
| // project card below image |
There was a problem hiding this comment.
i don't think flex is the best way to approach this, the elements in here are not evenly spaced
austin1im
left a comment
austin1im
left a comment
There was a problem hiding this comment.
looks good! just these two final things
| <h2>{project.title}</h2> | ||
| <h3>{project.date}</h3> | ||
| <h4>{project.mission}</h4> | ||
| <button className={project.button}> Learn More </button> |
There was a problem hiding this comment.
i don't think the button has any styling right now
| .projectGrid { | ||
| // for the project layout | ||
| display: flex; | ||
| padding: 0.625rem 6.25rem; |
There was a problem hiding this comment.
i think the x padding here is unnecessary
2 participants
