Skip to content

Comments

refactor: tests: add command_args: &[&str]#1608

Merged
kkysen merged 3 commits intomasterfrom
kkysen/refactor-tests-cmd-args
Feb 25, 2026
Merged

refactor: tests: add command_args: &[&str]#1608
kkysen merged 3 commits intomasterfrom
kkysen/refactor-tests-cmd-args

Conversation

@kkysen
Copy link
Contributor

@kkysen kkysen commented Feb 24, 2026

This can be used by #1589.

@kkysen kkysen requested a review from ahomescu February 24, 2026 00:57
@kkysen kkysen force-pushed the kkysen/c2rust-rust-tools branch from 049768c to d19fedd Compare February 24, 2026 01:00
@kkysen kkysen changed the base branch from kkysen/c2rust-rust-tools to kkysen/refactor-tests-compile-fmt February 24, 2026 01:05
@kkysen kkysen force-pushed the kkysen/refactor-tests-cmd-args branch from 2ae50d9 to 5a3444a Compare February 24, 2026 01:06
@kkysen kkysen requested a review from ahomescu February 24, 2026 01:18
This is especially important now that we've added `command_args`,
which are much more likely to contain weird characters.
We sanitize any non-alphanumeric characters besides `-_.` into `_`.
@kkysen kkysen force-pushed the kkysen/refactor-tests-cmd-args branch from ae0d048 to 8970818 Compare February 24, 2026 01:32
@kkysen kkysen force-pushed the kkysen/refactor-tests-compile-fmt branch from a8dc496 to eb35127 Compare February 24, 2026 01:32
…ividually

This avoids having extra spaces in the `debug_expr` when using `format!`.
Base automatically changed from kkysen/refactor-tests-compile-fmt to master February 25, 2026 00:45
@kkysen kkysen merged commit ce3bbc8 into master Feb 25, 2026
11 checks passed
@kkysen kkysen deleted the kkysen/refactor-tests-cmd-args branch February 25, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants