Draft
Conversation
2789124 to
6763a59
Compare
Contributor
Author
|
the trace ends at the PLT stub so the issue might not be related to the call gate prologues. |
Contributor
Author
|
Printing the backtrace for the broken test mentioned above gives this Although call gate control flow is wrong here ( |
6763a59 to
6f9ac54
Compare
backtrace(3) doesn't support unwinding through PLT stubs so this commit replaces it with libunwind. Since we want backtraces on by default I'm not sure if this is exactly what we want but it's good enough for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently prints a trace but at least brief checks on the
read_configtest shows the trace ends at compartment boundaries. Need to fix that, add anything else that might be useful and swapIA2_DEBUGforIA2_RELEASEwith opposite semantics. Closes #452.