Refactor how cubit is initialized and log messaging functionality#141
Merged
isteinbrecher merged 1 commit intoJun 19, 2026
Merged
Conversation
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR refactors the Cubit wrapper initialization handshake between the host and client processes, and moves Cubit message/log capture into the client via a message handler (with a Python 2 log-file fallback).
Changes:
- Refactor Cubit initialization so the host sends a single parameters dictionary (including
init_arguments) and the client performscubit.init(...)immediately after receiving it. - Remove host-side log-file polling/printing and introduce a client-side message handler to forward messages/errors back to the host (Python 2 uses a log-file fallback).
- Remove
temp_logfrom global configuration (conf.py) as log handling is no longer managed on the host side.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/cubitpy/cubit_wrapper/cubit_wrapper_host.py |
Refactors initialization flow and how init arguments are passed to the client. |
src/cubitpy/cubit_wrapper/cubit_wrapper_client.py |
Implements init-from-parameters, adds message handling, and Python 2 log fallback. |
src/cubitpy/conf.py |
Removes temp_log configuration that is no longer used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to the client for old cubit versions
isteinbrecher
force-pushed
the
refactor-init-and-messages
branch
from
804af61 to
4c6184a
Compare
isteinbrecher
had a problem deploying
to
cubit_secrets_trusted
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.