Skip to content

Remove deprecated BC #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isteinbrecher merged 1 commit into from
Jun 18, 2026
+1 −17
Merged

Remove deprecated BC #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/cubitpy/cubitpy_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"""This module contains ENums for types used in cubitpy as well as functions to
convert them to strings for cubit or 4C commands or the wrapper."""

import warnings
from enum import Enum, auto


Expand Down Expand Up @@ -286,10 +285,6 @@ class BoundaryConditionType(Enum):
beam_to_solid_volume_meshtying = auto()
beam_to_solid_surface_meshtying = auto()
beam_to_solid_surface_contact = auto()
# The following value "solid_to_solid_surface_contact" is deprecated and
# only kept for legacy reasons.
# Please use "solid_to_solid_contact" instead.
solid_to_solid_surface_contact = auto()
solid_to_solid_contact = auto()
periodic_rve_surface = auto()
periodic_rve_edge = auto()
Expand Down Expand Up @@ -330,17 +325,6 @@ def get_dat_bc_section_header(self, geometry_type):
return "BEAM INTERACTION/BEAM TO SOLID SURFACE CONTACT SURFACE"
elif self == self.point_coupling and (geometry_type == GeometryType.vertex):
return "DESIGN POINT COUPLING CONDITIONS"
elif self == self.solid_to_solid_surface_contact and (
geometry_type == GeometryType.surface
):
warnings.warn(
"The 'solid_to_solid_surface_contact' boundary condition enum is deprecated "
"and will be removed in a future version. "
"Use 'solid_to_solid_contact' instead.",
category=DeprecationWarning,
stacklevel=2,
)
return "DESIGN SURF MORTAR CONTACT CONDITIONS 3D"
elif self == self.solid_to_solid_contact and (
geometry_type == GeometryType.surface
):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cubitpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ def test_contact_condition_surface_to_surface():
cubit.add_node_set(
solid.surfaces()[0],
name="block1_contact_side",
bc_type=cupy.bc_type.solid_to_solid_surface_contact,
bc_type=cupy.bc_type.solid_to_solid_contact,
bc_description={"InterfaceID": 0, "Side": "Master"},
)
cubit.add_node_set(
Expand Down
Loading