Add message and error handlers#137
Merged
Merged
Conversation
isteinbrecher
had a problem deploying
to
cubit_secrets_trusted
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
Adds a mechanism for propagating Coreform/Cubit messages (warnings) and errors from the remote/client interpreter back to the host-side CubitPy API, plus a regression test to verify behavior.
Changes:
- Wrapped client-to-host channel responses to include captured Cubit/Coreform messages and errors.
- Host now emits captured messages via
warnings.warn(...)and raisesRuntimeErrorfor captured errors. - Added a test asserting that a known warning is surfaced as a Python warning and a known Cubit error becomes a Python exception.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_cubitpy.py | Adds coverage to ensure Cubit warnings/errors propagate through CubitPy APIs. |
| src/cubitpy/cubit_wrapper/cubit_wrapper_host.py | Interprets wrapped client responses; converts messages to warnings and errors to exceptions. |
| src/cubitpy/cubit_wrapper/cubit_wrapper_client.py | Introduces message handler + channel_send wrapper to ship messages/errors alongside return values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isteinbrecher
force-pushed
the
message-handler
branch
from
f7d169b to
c327b4f
Compare
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
isteinbrecher
force-pushed
the
message-handler
branch
from
c327b4f to
a22f04b
Compare
isteinbrecher
had a problem deploying
to
cubit_secrets_trusted
GitHub Actions
Failure
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
isteinbrecher
force-pushed
the
message-handler
branch
from
a22f04b to
dd06a1e
Compare
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
isteinbrecher
force-pushed
the
message-handler
branch
from
dd06a1e to
f545d8a
Compare
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a message handler that correctly passes on messages (usually warnings) and errors from Coreform to CubitPy.