fix(nwg-dock): move layout properties from colors.css to style.css#48
Open
justindotdevv wants to merge 1 commit intoimbypass:mainfrom
Open
fix(nwg-dock): move layout properties from colors.css to style.css#48justindotdevv wants to merge 1 commit intoimbypass:mainfrom
justindotdevv wants to merge 1 commit intoimbypass:mainfrom
Conversation
justindotdevv
force-pushed
the
fix/colors-css-layout-properties
branch
from
e0d2755 to
4f1cc65
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the nwg-dock-hyprland theme hook to keep colors.css limited to color theming, and moves structural/layout styling into the generated style.css, aligning with the intended separation described in issue #47.
Changes:
- Removes non-color properties (
border,padding) and inline comments from the generated colors CSS content. - Adds layout-related border properties (
border-style,border-width,border-radius) to the default#boxstyling in the generatedstyle.css.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justindotdevv
force-pushed
the
fix/colors-css-layout-properties
branch
from
4f1cc65 to
c9d522f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
Moves non-color properties (
border,padding) from the colors.css template to style.css where they belong. Removes inline comments from the colors template.Changes:
border: 2px solidandpadding: 3pxfrom colors templateborder-style,border-width,border-radiusto#boxin style.css template