First attempt at a Slimmage Background Image plugin#55
Open
protherj wants to merge 6 commits intoimazen:unstablefrom
Open
First attempt at a Slimmage Background Image plugin#55protherj wants to merge 6 commits intoimazen:unstablefrom
protherj wants to merge 6 commits intoimazen:unstablefrom
Conversation
Member
|
You need to have a max-width applied to the element for getCssPixels to work. If there's no constraint, it returns null. Nearly all frameworks include Likewise, a max of 2048 is the default configuration for maximum width. |
Member
|
You should be able to reset to the updated version of 'unstable' and get a cleaner PR. I apologize for 'unstable' being behind 'master'. No idea how that happened, but it is corrected now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first attempt at a Background Images plugin based on the Pull Request #37 from dancek. Slimmage has changed considerably and I hope I got it generally right.
Two problems I'm currently having that I need help with:
The var cssMaxWidth = s'getCssPixels'; call always returns null for me and that causes the getImageInfo to return null as well. Thus, the fall back to 3000 if falsy.
The call to getImageInfo always seems to return an image with a width of 2048. It's probably my CSS setup somehow, but any help determining the cause would rock.
Also, is this plugin setup properly? I didn't have any examples to go off of, so any help with getting it right is appreciated.
Thanks