Fix/dockerfile non root user#397
Open
okyashgajjar wants to merge 3 commits into
Open
Conversation
Owner
|
@okyashgajjar update your branch with the latest main changes |
okyashgajjar
force-pushed
the
fix/dockerfile-non-root-user
branch
from
71ad0eb to
58b9410
Compare
Author
|
Done @imDarshanGK Check this now. |
okyashgajjar
force-pushed
the
fix/dockerfile-non-root-user
branch
2 times, most recently
from
5c43a10 to
b62a98e
Compare
Author
whoever contributed to this an updates is failing due to frontend checks errors. |
Author
|
Although I updated my branches with latest main changes You can merge it also issued PR #437 - check this and allow me i'll update the code. |
Owner
|
@okyashgajjar update the branch with the latest main changes |
okyashgajjar
force-pushed
the
fix/dockerfile-non-root-user
branch
from
b62a98e to
d04d9c9
Compare
Author
|
@imDarshanGK Done updated, please merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a non-root user directive to both
Dockerfileandbackend/Dockerfile. Neither file specified a USER directive,meaning containers ran as root by default. If an attacker gains
container access, they would have full root control — violating
the principle of least privilege.
Fix applied to both files:
Related Issue
Fixes #389
Type of change
Checklist
mainpytest -vand all tests passfix: add non-root USER directive to DockerfilesTest evidence
pytest -v # 93 passed in 3.96s