fix: prevent path traversal in zip member validation#396
Open
okyashgajjar wants to merge 1 commit into
Open
Conversation
Owner
|
@okyashgajjar |
okyashgajjar
force-pushed
the
fix/path-traversal-vulnerability
branch
from
0572323 to
9e7569b
Compare
Author
|
Done @imDarshanGK Check this now. |
okyashgajjar
force-pushed
the
fix/path-traversal-vulnerability
branch
2 times, most recently
from
b4b72b6 to
aec4516
Compare
Owner
|
@okyashgajjar update the branch with the latest main changes |
okyashgajjar
force-pushed
the
fix/path-traversal-vulnerability
branch
from
aec4516 to
9e4ef45
Compare
Author
|
done @imDarshanGK please merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a path traversal vulnerability in
_safe_zip_name()function inbackend/app/routers/analyze.py. The original function only strippedleading slashes but did not reject
..path components, allowingattackers to escape the intended directory and access sensitive files.
Related Issue
Fixes #386
Type of change
Checklist
mainpytest -vand all tests passfix: prevent path traversal in zip member validationTest evidence