Skip to content

fix(remote-mobile): clear stale waiting input state#700

Merged
ilysenko merged 1 commit into
ilysenko:mainfrom
Yo-DDV:fix/remote-waiting-input-state
Jul 8, 2026
Merged

fix(remote-mobile): clear stale waiting input state#700
ilysenko merged 1 commit into
ilysenko:mainfrom
Yo-DDV:fix/remote-waiting-input-state

Conversation

@Yo-DDV

@Yo-DDV Yo-DDV commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • tighten the Linux webview recovery around restored waitingOnUserInput runtime state
  • keep that state active only when a real pending user-input request is still present
  • keep permission waits, real user-input waits, malformed active states, and already-patched bundles behaving as before

Why

While testing #639, I could reproduce one stale shape in the Linux webview patch path: a restored thread can still report waitingOnUserInput after the request list no longer contains a matching input request. In that state, remote mobile can keep looking busy even though the conversation is ready for the next message.

The permission wait path already checks the request list before surfacing that state. This adds the same kind of guard for user-input waits, while keeping unknown active shapes on the safe loading side.

Refs #639.

Tests

  • node --check scripts/patches/impl/webview/index.js && node --check scripts/patch-linux-window-ui.test.js
  • git diff --check
  • node --test --test-name-pattern "remote status|empty active runtime status|upgrades already-patched" scripts/patch-linux-window-ui.test.js
  • node --test scripts/patch-linux-window-ui.test.js
  • node --test linux-features/*/test.js
  • bash tests/scripts_smoke.sh
  • make check && make test
  • patcher dry-run twice against a copied installed content tree; the webview bundle contains the new helper, call-site wiring, stale pending guard, and safe optional flag handling after patching

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The fix is narrow, keeps real pending input/permission waits intact, and CI is green.

@ilysenko ilysenko merged commit a860098 into ilysenko:main Jul 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants