fix(remote-mobile): clear stale waiting input state#700
Merged
Conversation
ilysenko
approved these changes
Jul 8, 2026
ilysenko
left a comment
Owner
There was a problem hiding this comment.
Looks good. The fix is narrow, keeps real pending input/permission waits intact, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitingOnUserInputruntime stateWhy
While testing #639, I could reproduce one stale shape in the Linux webview patch path: a restored thread can still report
waitingOnUserInputafter the request list no longer contains a matching input request. In that state, remote mobile can keep looking busy even though the conversation is ready for the next message.The permission wait path already checks the request list before surfacing that state. This adds the same kind of guard for user-input waits, while keeping unknown active shapes on the safe loading side.
Refs #639.
Tests
node --check scripts/patches/impl/webview/index.js && node --check scripts/patch-linux-window-ui.test.jsgit diff --checknode --test --test-name-pattern "remote status|empty active runtime status|upgrades already-patched" scripts/patch-linux-window-ui.test.jsnode --test scripts/patch-linux-window-ui.test.jsnode --test linux-features/*/test.jsbash tests/scripts_smoke.shmake check && make test