Skip to content
This repository was archived by the owner on Dec 29, 2025. It is now read-only.

Add "json" support#88

Open
iosifnicolae2 wants to merge 33 commits intoildus:masterfrom
iosifnicolae2:master
Open

Add "json" support#88
iosifnicolae2 wants to merge 33 commits intoildus:masterfrom
iosifnicolae2:master

Conversation

@iosifnicolae2
Copy link

Fixes #87

@Denchick
Copy link
Contributor

I'm just been walking around
It would be cool if you add tests also

@iosifnicolae2
Copy link
Author

Unfortunately I'm not that used on writing c++ code, so I don't know exactly how add the appropriate tests..

@Denchick
Copy link
Contributor

Well, you don't need to know how to write tests in C++ :)
There is a folder tests in the root of the repository, inside there are also two folders: sql and expected.
How to run tests you can see in Makefile

@manakao
Copy link

manakao commented Sep 7, 2022

hello guys, i have same issue. when this PR will be merged?

@Denchick
Copy link
Contributor

@ildus, hi! Could you approve to run tests here?

@ildus
Copy link
Owner

ildus commented Sep 22, 2023

@iosifnicolae2 could you add sql tests for it (look for the comment from @Denchick)? That will show that the patch is working. Also please remove .idea files.

@iosifnicolae2
Copy link
Author

@ildus sorry, but currently I don't have time to invest into creating a proper PR request, if anyone is interesting into doing this, it would be great.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not map type <'json')>

4 participants