refactor(directory): rename worker iii-directory -> directory#266
Draft
guibeira wants to merge 2 commits into
Draft
refactor(directory): rename worker iii-directory -> directory#266guibeira wants to merge 2 commits into
guibeira wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughRenames the ChangesWorker rename: iii-directory → directory
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…irectory # Conflicts: # harness/README.md # harness/docs/architecture.md # harness/iii.worker.yaml
Contributor
skill-check — worker0 verified, 19 skipped (no docs/).
Four for four. Nicely done. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
directory/tests/e2e/run-tests.sh (1)
15-15: 💤 Low valueRemove the unused
HEREvariable.Variable
HEREis declared on line 15 but never referenced in the script. All assertions and operations use$ROOT_DIRor other variables directly.Proposed fix
HERE="$ROOT_DIR" # assertion body refers to $HERE / $GLOBAL -HERE="$ROOT_DIR" PORT="${PORT:-49134}"Note: Remove the redundant assignment on line 15, or if
HEREwas intentionally added for future use, remove the misleading comment on line 15.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@directory/tests/e2e/run-tests.sh` at line 15, The HERE variable is declared and assigned the value of ROOT_DIR but is never referenced anywhere in the script, making it redundant code. Remove the assignment of the HERE variable since all assertions and operations in the script use ROOT_DIR or other variables directly instead of the HERE alias.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@directory/src/main.rs`:
- Around line 35-37: The multi-line import statement for download_worker_skills,
reconcile_decision, and InFlightGuard from directory::functions::download is
failing cargo fmt validation. Collapse this import block from its current
multi-line format into a single line by removing the line breaks and moving all
imported items onto one line while keeping the curly brace syntax intact.
---
Nitpick comments:
In `@directory/tests/e2e/run-tests.sh`:
- Line 15: The HERE variable is declared and assigned the value of ROOT_DIR but
is never referenced anywhere in the script, making it redundant code. Remove the
assignment of the HERE variable since all assertions and operations in the
script use ROOT_DIR or other variables directly instead of the HERE alias.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 43e4f9c4-72a8-44c3-8fc5-b779df40b3ef
⛔ Files ignored due to path filters (1)
directory/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (69)
.github/scripts/parse_publish_workers_input.py.github/scripts/validate_worker.py.github/workflows/create-tag.yml.github/workflows/release.ymlREADME.mdconsole/web/src/components/chat/directory/parsers.tsconsole/web/src/components/chat/worker/__tests__/parsers.test.tsconsole/web/src/hooks/use-worker-lifecycle.tsconsole/web/src/stories/fixtures/engine-fixtures.tsconsole/web/src/stories/fixtures/worker-fixtures.tsdirectory/Cargo.tomldirectory/README.mddirectory/build.rsdirectory/config.yamldirectory/examples/test_registry.rsdirectory/iii.worker.yamldirectory/skills/SKILL.mddirectory/src/config.rsdirectory/src/fs_source.rsdirectory/src/functions/download.rsdirectory/src/functions/engine_fn.rsdirectory/src/functions/error.rsdirectory/src/functions/mod.rsdirectory/src/functions/prompts.rsdirectory/src/functions/registry.rsdirectory/src/functions/skills.rsdirectory/src/lib.rsdirectory/src/main.rsdirectory/src/manifest.rsdirectory/src/sources/git.rsdirectory/src/sources/mod.rsdirectory/src/sources/registry.rsdirectory/src/trigger_types.rsdirectory/tests/bdd.rsdirectory/tests/common/engine.rsdirectory/tests/common/mod.rsdirectory/tests/common/workers.rsdirectory/tests/common/world.rsdirectory/tests/e2e/.gitignoredirectory/tests/e2e/README.mddirectory/tests/e2e/config.yamldirectory/tests/e2e/reports/.gitkeepdirectory/tests/e2e/run-tests.shdirectory/tests/features/download_registry.featuredirectory/tests/features/download_repo.featuredirectory/tests/features/prompts.featuredirectory/tests/features/read.featuredirectory/tests/features/registry_worker_info.featuredirectory/tests/features/registry_worker_list.featuredirectory/tests/steps/download_registry.rsdirectory/tests/steps/download_repo.rsdirectory/tests/steps/mod.rsdirectory/tests/steps/prompts.rsdirectory/tests/steps/read.rsdirectory/tests/steps/registry.rsdocs/architecture/skills-and-permissions.mddocs/architecture/testing-and-ci.mddocs/sops/new-worker.mdharness/README.mdharness/docs/architecture.mdharness/docs/workers/harness.mdharness/iii.worker.yamlharness/src/harness/iii.worker.yamlharness/src/turn-orchestrator/prompt/anthropic.tsharness/src/turn-orchestrator/prompt/default.tsharness/src/turn-orchestrator/prompt/gpt.tsharness/src/turn-orchestrator/prompt/kimi.tsharness/tests/turn-orchestrator/system-prompt.test.tsshell/README.md
Comment on lines
+35
to
37
| use directory::functions::download::{ | ||
| download_worker_skills, reconcile_decision, InFlightGuard, | ||
| }; |
There was a problem hiding this comment.
Fix cargo fmt --check failure on the import block.
The current multi-line import shape is failing CI formatting checks; collapse it to the formatter-expected single line.
Suggested fix
-use directory::functions::download::{
- download_worker_skills, reconcile_decision, InFlightGuard,
-};
+use directory::functions::download::{download_worker_skills, reconcile_decision, InFlightGuard};📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| use directory::functions::download::{ | |
| download_worker_skills, reconcile_decision, InFlightGuard, | |
| }; | |
| use directory::functions::download::{download_worker_skills, reconcile_decision, InFlightGuard}; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@directory/src/main.rs` around lines 35 - 37, The multi-line import statement
for download_worker_skills, reconcile_decision, and InFlightGuard from
directory::functions::download is failing cargo fmt validation. Collapse this
import block from its current multi-line format into a single line by removing
the line breaks and moving all imported items onto one line while keeping the
curly brace syntax intact.
Source: Pipeline failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the in-repo worker
iii-directory->directory(Task 1 of the remove-iii-prefix plan). This is a coordinated rename: folder, crate/bin/lib identifiers, worker manifestname:, dependency keys, CI allowlists, release tag pattern, console TS, and docs all change together.The publish CI enforces that a worker's
iii.worker.yamlname:must equal its folder name (validate_worker.py), so folder rename + manifestname:+ CI allowlists are coupled and changed in one commit.Changes
git mv iii-directory -> directorydirectory/Cargo.toml: package/[[bin]]/[lib]name ->directory(theiii-sdkdependency line is untouched)directory/iii.worker.yaml:name: directory,bin: directoryiii_directory->directoryacross all Rust sources/testsharness/iii.worker.yamlandharness/src/harness/iii.worker.yamliii-directory->directoryrelease.ymltag patterndirectory/v*,create-tag.ymlallowlist,validate_worker.pyALLOWED entry,parse_publish_workers_input.pyallowed-set entryVerification
cargo buildindirectory/: PASScargo test --lib: 243 passed, 0 failedcargo test --test bdd -- --tags @pure: compiles + runs clean (no@pure-tagged scenarios exist in feature files; engine-bound scenarios skip without a running engine — unrelated to the rename)validate_worker.py --worker directory --base-ref main --source-changed '["directory"]': exit 0 (name now matches folder)iii-directory/iii_directory(excluding target/ + node_modules): emptyiii-sdk,iii-state,iii-stream,iii-queue,iii-observability) left byte-identical — confirmed no external-dep lines in the Cargo.toml diffNotes
validate_worker.py.Summary by CodeRabbit
Chores
iii-directoryworker todirectoryacross the codebase, including configuration files, documentation, build metadata, and internal references.Documentation
directoryworker naming.