refactor(lsp): rename worker iii-lsp -> lsp#265
Draft
guibeira wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the in-repo worker
iii-lsp->lsp(folder, crate package,[lib],[[bin]],iii.worker.yamlname:/bin:, internal identity strings) and updates CI to match. Task 2 of theremove-iii-prefixplan.Changes
git mv iii-lsp lsp.lsp/Cargo.toml: package/lib/binname = "lsp".iii-sdkdependency left byte-identical.lsp/iii.worker.yaml:name: lsp,bin: lsp;interface_smoke: falseretained.iii_lsplib identifier ->lspacross the worker folder; worker-identity string literals (WorkerMetadata.name, LSPServerInfo.name, diagnosticsource, CLI command name, log prefixes) updated tolsp..github/workflows/release.yml: tag patterniii-lsp/v*->lsp/v*..github/workflows/create-tag.yml: allowlistiii-lsp->lsp;iii-lsp-vscodeentry + special-case block left as-is.validate_worker.py/parse_publish_workers_input.py: noiii-lspentry existed (onlyiii-directory), so no change needed.README.mdworker table +lsp/README.mdupdated to thelspbinary name.VS Code extension (intentionally preserved)
The marketplace identity
iii-lsp, theiii-lsp.*config namespace,config.get(...)keys, and the pinned-release installer flow iniii-lsp-vscode/are kept unchanged to avoid breaking users'settings.jsonand marketplace continuity. Onlyextension.jswas updated: the PATH binary lookup now preferslspand falls back to the legacyiii-lspname.External SDK deps
No references to
iii-sdk,iii-observability,iii-state,iii-stream, oriii-queuewere touched (out of scope; source lives in the SDK repo).Verification
cargo build(lsp): PASS.cargo test(lsp): PASS — 61 unit + 2 integration tests.validate_worker.py --worker lsp: PASS (name=lspmatches folder, strict mode).iii-lsphits are only theiii-lsp-vscode/extension (marketplace name, config namespace, pinned installer/tests), theextension.jsPATH fallback,iii-lsp-vscodeCI entries, and explanatory comments referencing the stdio-worker example.