Skip to content

refactor(lsp): rename worker iii-lsp -> lsp#265

Draft
guibeira wants to merge 1 commit into
mainfrom
refactor/rename-iii-lsp
Draft

refactor(lsp): rename worker iii-lsp -> lsp#265
guibeira wants to merge 1 commit into
mainfrom
refactor/rename-iii-lsp

Conversation

@guibeira

Copy link
Copy Markdown
Collaborator

Summary

Renames the in-repo worker iii-lsp -> lsp (folder, crate package, [lib], [[bin]], iii.worker.yaml name:/bin:, internal identity strings) and updates CI to match. Task 2 of the remove-iii-prefix plan.

Changes

  • git mv iii-lsp lsp.
  • lsp/Cargo.toml: package/lib/bin name = "lsp". iii-sdk dependency left byte-identical.
  • lsp/iii.worker.yaml: name: lsp, bin: lsp; interface_smoke: false retained.
  • iii_lsp lib identifier -> lsp across the worker folder; worker-identity string literals (WorkerMetadata.name, LSP ServerInfo.name, diagnostic source, CLI command name, log prefixes) updated to lsp.
  • .github/workflows/release.yml: tag pattern iii-lsp/v* -> lsp/v*.
  • .github/workflows/create-tag.yml: allowlist iii-lsp -> lsp; iii-lsp-vscode entry + special-case block left as-is.
  • validate_worker.py / parse_publish_workers_input.py: no iii-lsp entry existed (only iii-directory), so no change needed.
  • Docs: root README.md worker table + lsp/README.md updated to the lsp binary name.

VS Code extension (intentionally preserved)

The marketplace identity iii-lsp, the iii-lsp.* config namespace, config.get(...) keys, and the pinned-release installer flow in iii-lsp-vscode/ are kept unchanged to avoid breaking users' settings.json and marketplace continuity. Only extension.js was updated: the PATH binary lookup now prefers lsp and falls back to the legacy iii-lsp name.

External SDK deps

No references to iii-sdk, iii-observability, iii-state, iii-stream, or iii-queue were touched (out of scope; source lives in the SDK repo).

Verification

  • cargo build (lsp): PASS.
  • cargo test (lsp): PASS — 61 unit + 2 integration tests.
  • validate_worker.py --worker lsp: PASS (name=lsp matches folder, strict mode).
  • Sanity grep: remaining iii-lsp hits are only the iii-lsp-vscode/ extension (marketplace name, config namespace, pinned installer/tests), the extension.js PATH fallback, iii-lsp-vscode CI entries, and explanatory comments referencing the stdio-worker example.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Building Building Preview Jun 15, 2026 1:08pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de662bad-2038-47dd-bb23-337b0e7f0b5c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/rename-iii-lsp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant