chore: rename repo from java-api to java-api-17#4
Merged
cesarcoatl merged 1 commit intomainfrom Dec 8, 2025
Merged
Conversation
rename default branch from 17 to main
Contributor
Reviewer's GuideUpdates repository metadata and documentation to reflect the rename from File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In the root README, the
[java-api-stubs]link still points togithub.com/ignition-devs/java-api/tree/main/java-api-stubsinstead of the renamedjava-api-17repository, which will likely lead to a broken or outdated link. - The added
"mypy[python2]==0.971"in thepython3 -m pip installexample forjava-api-stubsmay be surprising for users installing only the stubs; consider documenting why it is required there or moving it into project configuration (e.g., extras/requirements) rather than the README install snippet.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the root README, the `[java-api-stubs]` link still points to `github.com/ignition-devs/java-api/tree/main/java-api-stubs` instead of the renamed `java-api-17` repository, which will likely lead to a broken or outdated link.
- The added `"mypy[python2]==0.971"` in the `python3 -m pip install` example for `java-api-stubs` may be surprising for users installing only the stubs; consider documenting why it is required there or moving it into project configuration (e.g., extras/requirements) rather than the README install snippet.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename default branch from 17 to main
Summary by Sourcery
Update repository references and CI configuration to reflect the rename to java-api-17 and the new main default branch.
Enhancements:
CI: