Suppression de code non utilisé dans processPatchAsync de gdal_processing.js#451
Merged
Merged
Conversation
5e60f80 to
0b85725
Compare
Collaborator
Author
|
@ftoromanoff c'est bon pour review |
ftoromanoff
reviewed
Jun 4, 2026
| urlOpiSecIr = path.join(dnameSec, fnameSec); | ||
| } | ||
| } | ||
| const { urlOpiRefRgb, urlOpiRefIr } = patch; |
Collaborator
Author
There was a problem hiding this comment.
Je peux inversé mais ça va grossir la refactor car je vais devoir changer en amont et plus bas à tout les endroits qu'ils sont utilisé.
Je propose de le mettre dans la re-factorisation global, pour pas que la PR prennent trop de temps
Collaborator
Author
There was a problem hiding this comment.
Celle parlé en réunion où j'ai une branche de re-factorisation sur laquelle j'applique ou vais appliquer les re-factorisations que l'on parle pendant les PR et les réunions, qui passera en plusieurs petites PR pour pas avoir un truc énorme quand les priorités sur les deux autres PR (#450 et #449) et la saisie de block seront fait
b280a4c to
674afa1
Compare
ftoromanoff
reviewed
Jun 9, 2026
ftoromanoff
approved these changes
Jun 9, 2026
Collaborator
Author
|
Nettoyage des commits |
b5168db to
80dc6df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-factorisation de :
processPatchPolygonAsync