Fix brand resolution bug introduced with Assembler support: vin._brand not set properly#30
Merged
Merged
Conversation
iskigow
commented
Jun 9, 2025
iskigow
commented
Contributor
- Initialize _brand with None;
- Improve test coverage
- Initialize _brand as None; - Improve coverage test;
- Ruff check;
Contributor
Author
|
@idlesign |
Pull Request Test Coverage Report for Build 15560102889Details
💛 - Coveralls |
idlesign
reviewed
Jun 10, 2025
- Remove OrdederDict use;
Contributor
Author
|
@idlesign OrdederDict removed! |
idlesign
approved these changes
Jun 13, 2025
Owner
|
Thank you. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.