Skip to content

Add 'isDefined'#7

Open
mhgharieb wants to merge 2 commits intoiden3:mainfrom
mhgharieb:main
Open

Add 'isDefined'#7
mhgharieb wants to merge 2 commits intoiden3:mainfrom
mhgharieb:main

Conversation

@mhgharieb
Copy link
Copy Markdown

'isDefined' is a function used by 'getDecoratedOutput'

@mhgharieb
Copy link
Copy Markdown
Author

Also you must add
const utils = require("./utils");

to wasm/tester.js and c/tester.js

@alrubio
Copy link
Copy Markdown
Collaborator

alrubio commented Sep 1, 2022

Thanks for the proposal, but I don't like to add the dependency to utiils.js and add there isDefined. I prefer to add it at the end of wasm/tester.js and remove utils. before its use.
Do you want to change your PR? If so I'll accept it.

@mhgharieb mhgharieb reopened this Nov 6, 2022
@mhgharieb
Copy link
Copy Markdown
Author

@alrubio I made the changes as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants