Add an option to compile circuits in Docker for quick and easy installation #2
Open
vkonst wants to merge 2 commits intoiden3:mainfrom
Open
Add an option to compile circuits in Docker for quick and easy installation #2vkonst wants to merge 2 commits intoiden3:mainfrom
vkonst wants to merge 2 commits intoiden3:mainfrom
Conversation
aspiers
approved these changes
Nov 3, 2021
| -v /etc/passwd:/etc/passwd:ro \ | ||
| -v /etc/group:/etc/group:ro \ | ||
| --user $(id -u) \ | ||
| aspiers/circom circom $@ |
There was a problem hiding this comment.
Hopefully this can be replaced with iden3/circom or even just circom at some point :-)
| options.compiler += `-v /etc/group:/etc/group:ro `; | ||
| options.compiler += `--user ${uid} `; | ||
| } | ||
| options.compiler += "aspiers/circom circom"; |
There was a problem hiding this comment.
Same here - hopefully can be replaced with iden3/circom or circom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circuits compilation inside a Docker container running
circom.To simplify/avoid installation of dependencies (
circom):circomin a conainer(The
CIRCOM_DOCKERenv param shall be set to any non-zero value to enable this mode)