Skip to content

style: 🎨 match buttons to figma#565

Open
Windslash123 wants to merge 3 commits into
mainfrom
aa/update-meeting-buttons
Open

style: 🎨 match buttons to figma#565
Windslash123 wants to merge 3 commits into
mainfrom
aa/update-meeting-buttons

Conversation

@Windslash123
Copy link
Copy Markdown
Contributor

@Windslash123 Windslash123 commented Jun 3, 2026

Description

Update meeting buttons to match Figma, including color and spacing.

Figma ref:
image

Recording/Screenshots

Before

image

After

image

Test Plan

Issues

  • Closes #

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@Windslash123 Windslash123 requested a review from ethancha0 June 3, 2026 21:45
@ethancha0
Copy link
Copy Markdown
Collaborator

Are there any buttons in the Figma that use the outline variant, but not with the color="inherit" prop?

(do all outlined buttons have black text)

if no, we can prob just adjust the outline variant to have black text by default

@Windslash123
Copy link
Copy Markdown
Contributor Author

Windslash123 commented Jun 3, 2026

@ethancha0 I think currently, all the outlined buttons have the black outline/text in the Figma, but there are quite a few colored outlined buttons in the codebase. Most, if not all, of those buttons should be contained instead of outlined, such as the delete meeting button (but that requires a longer fix because it needs its own modal). For now, I'll add the default black text/outline to the theme for outlined buttons, and remove the color=inherit prop for the relevant buttons.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/theme.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants