Add GitHub Actions workflows to migrate away from Travis-CI#587
Open
everops-john wants to merge 22 commits intoichord:masterfrom
Open
Add GitHub Actions workflows to migrate away from Travis-CI#587everops-john wants to merge 22 commits intoichord:masterfrom
everops-john wants to merge 22 commits intoichord:masterfrom
Conversation
Rebase agains ichord/At.js (1/3)
Dispatch event on <enter> (2/3)
Bump version to 1.5.2 (3/3)
Resolve incorrect peer dependency error
The parameter name for setTimeout was shadowing the `e` parameter, causing that to be `undefined` when we called `dispatch`.
Not shadowing event parameter passed to dispatch
Remove peer dependency requirement
…ce_after_@mention_cursor_jump [ZD-2703623] deleting space after @mention cursor jump
In `at.js` the zero width joiner unicode character (\u200D) is inserted after an at-mention is inserted into the rich text editor (for our use case, the at-mention is a condition placeholder). This zwj character causes problems with the cursor - additionally, the use case for the zwj character is very specific and in its current form does not do anything. By switching to a zero width space character we can preserve the spirit of the original implementation and fix the cursor issue. This was tested on Google Chrome, Firefox, and Safari. The zwj character was added to `at.js` in this PR: #7 - it's important to make sure we are not introducing any regressions with this change.
Change zwj to zws
Add a guard for the presence of the event object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://zendesk.atlassian.net/browse/EP-4414