Skip to content

Make canvasSize work on windows.#21

Closed
dchapes wants to merge 3 commits into
ichinaski:masterfrom
dchapes:patch-1
Closed

Make canvasSize work on windows.#21
dchapes wants to merge 3 commits into
ichinaski:masterfrom
dchapes:patch-1

Conversation

@dchapes
Copy link
Copy Markdown

@dchapes dchapes commented May 9, 2021

Resolves #15

@dchapes
Copy link
Copy Markdown
Author

dchapes commented May 9, 2021

Note: I use mercurial with hggit so I'm not sure if the file copies in the first commit correctly got detected as repository file copies on the conversion to git (so that things like git blame within the new files will know what lines haven't been changed since the original).

@dchapes
Copy link
Copy Markdown
Author

dchapes commented May 9, 2021

Note the comment on #22 (comment) , these two PRs are slightly incompatible; I'll fix up one if you accept the other.

@dchapes
Copy link
Copy Markdown
Author

dchapes commented May 9, 2021

I just noticed PR #3.
Sadly, although I tested this on a windows guest within VirtualBox it did have some issues with colours; perhaps the same issue as with the previous PR.
If it's just a matter of only having 16 colours I do have some code elsewhere that can shrink a palette. Perhaps further downgrading incoming images to 16 colours would be sufficient? If so I could try adding that, if not feel free to close this PR too.

Sorry for not looking at the previously closed PRs before submitting this one.

@dchapes dchapes closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on windows it shows this

1 participant