Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-chicken-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ice/pkg': major
---

feat: remove vitest/jest define method and support vitest in-source test
Comment on lines +1 to +5
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 描述目前聚焦在示例 Jest 的 moduleNameMapper 修复,但本 changeset 声明了 @ice/pkg 的 major 变更(移除 defineJestConfig/defineVitestConfig 等公共 API、默认 define/transform 行为调整)。建议同步更新 PR 描述,明确包含的破坏性变更点与迁移方式,避免发布说明与实际变更不一致。

Copilot uses AI. Check for mistakes.
7 changes: 3 additions & 4 deletions examples/react-component/jest.config.mjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import pkgService, { defineJestConfig } from '@ice/pkg';

export default defineJestConfig(pkgService, {
export default {
preset: 'ts-jest',
setupFilesAfterEnv: ['<rootDir>/jest-setup.ts'],
testEnvironment: 'jest-environment-jsdom',
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该示例源码(如 Test 组件)直接访问 __DEV__,但当前 Jest 配置/初始化脚本没有注入该全局常量,运行测试会在运行时抛出 ReferenceError。建议在 Jest 启动前通过 setupFiles / setupFilesAfterEnv 设置 globalThis.__DEV__(或在 Jest 配置的 globals 中提供 __DEV__)。

Suggested change
testEnvironment: 'jest-environment-jsdom',
testEnvironment: 'jest-environment-jsdom',
globals: {
__DEV__: true,
},

Copilot uses AI. Check for mistakes.
moduleNameMapper: {
'^@/(.*)$': '<rootDir>/src/$1',
'\\.module\\.(css|scss|less)$': 'identity-obj-proxy',
'\\.(css|less|scss)$': '<rootDir>/__mocks__/styleMock.js',
},
});
};
4 changes: 2 additions & 2 deletions examples/react-component/vitest.config.mts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pkgService, { defineVitestConfig } from '@ice/pkg';
import { defineConfig } from 'vitest/config';

export default defineVitestConfig(pkgService, () => ({
export default defineConfig(() => ({
test: {
environment: 'jsdom',
setupFiles: ['./vitest-setup.ts'],
Expand Down
1 change: 1 addition & 0 deletions packages/pkg/src/engine/shared/define.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ export default function getDefaultDefineValues(mode: NodeEnvMode) {
return {
__DEV__: JSON.stringify(mode !== 'production'),
'process.env.NODE_ENV': JSON.stringify(mode),
'import.meta.vitest': 'undefined',
};
}
2 changes: 0 additions & 2 deletions packages/pkg/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export * from './test/index.js';

export * from './types.js';

export { getBuiltInPlugins } from './utils.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/pkg/src/tasks/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class TransformRunner extends Runner<OutputResult> {
const entry = config.entry as Record<string, string>;
const allEntryDirs = getTransformEntryDirs(rootDir, entry);
const entryRoot = config.entryRoot ?? getTransformEntryRoot(rootDir, entry);
const excludes = config.excludes ?? [];
const excludes = config.excludes ?? ['**/__tests__/**'];

this.cache = {
allEntryDirs,
Expand Down
53 changes: 0 additions & 53 deletions packages/pkg/src/test/defineJestConfig.ts

This file was deleted.

41 changes: 0 additions & 41 deletions packages/pkg/src/test/defineVitestConfig.ts

This file was deleted.

20 changes: 0 additions & 20 deletions packages/pkg/src/test/getTaskConfig.ts

This file was deleted.

2 changes: 0 additions & 2 deletions packages/pkg/src/test/index.ts

This file was deleted.

1 change: 1 addition & 0 deletions packages/pkg/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export interface TransformUserConfig {
* Exclude all files matching any of those conditions.
* - `string` to match any paths by `minimatch` glob patterns
* - An `array` to match at least one of the conditions
* Default: files in __tests__ directories are excluded by default.
* @see https://github.com/isaacs/minimatch
*/
excludes?: string | string[];
Expand Down
20 changes: 20 additions & 0 deletions packages/pkg/tests/defaultDefine.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { describe, expect, it } from 'vitest';
import getDefaultDefineValues from '../src/engine/shared/define';

describe('getDefaultDefineValues', () => {
it('should include vitest in-source test guard by default', () => {
expect(getDefaultDefineValues('development')).toEqual({
__DEV__: 'true',
'process.env.NODE_ENV': '"development"',
'import.meta.vitest': 'undefined',
});
});

it('should preserve production defaults', () => {
expect(getDefaultDefineValues('production')).toEqual({
__DEV__: 'false',
'process.env.NODE_ENV': '"production"',
'import.meta.vitest': 'undefined',
});
});
});
Loading
Loading