Generate after removing report builder from spec#36
Conversation
Reviewer's GuideThis PR regenerates the Python client after removing the report builder specification, updating the OpenAPI and SDK versions across the codebase, pruning all report-related APIs, models, tests, and docs, and applying a few manual fixes to lint configuration and Pydantic validation. Class diagram for removed report-related models and APIsclassDiagram
class ReportApi
class Report
class ReportList
class ReportParameters
class GetReportTypes200ResponseInner
ReportApi --|> Report
ReportApi --|> ReportList
ReportApi --|> ReportParameters
ReportApi --|> GetReportTypes200ResponseInner
Class diagram for updated Result model validatorclassDiagram
class Result {
+result_validate_enum(value)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR regenerates OpenAPI client code after removing the report builder functionality from the API specification, updating the version from 2.7.4 to 2.8.0. The changes reflect the removal of report-related APIs and models while updating version references throughout the codebase.
- Remove all report-related API endpoints, models, and documentation
- Update OpenAPI version from 2.7.4 to 2.8.0 and SDK version from 3.0.0 to 3.1.0
- Remove missing @classmethod decorator from Pydantic field validator
Reviewed Changes
Copilot reviewed 123 out of 123 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple test files | Updated OpenAPI version reference in generated test headers |
| pyproject.toml | Added N805 lint rule ignore for Pydantic validators using cls parameter |
| ibutsu_client/models/result.py | Removed missing @classmethod decorator from field validator |
| Report-related files | Complete removal of report API, models, tests, and documentation |
| Version files | Updated API version to 2.8.0 and SDK version to 3.1.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure the SDK version bump in version is also reflected in your packaging metadata (e.g. pyproject.toml) to avoid mismatches during releases.
- Review any consumer code or documentation that relied on the removed ReportApi and related report models to update or remove those references.
- Verify that dropping the @classmethod decorator on the result_validate_enum validator works as intended with your target Pydantic version and still executes the validation logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the SDK version bump in __version__ is also reflected in your packaging metadata (e.g. pyproject.toml) to avoid mismatches during releases.
- Review any consumer code or documentation that relied on the removed ReportApi and related report models to update or remove those references.
- Verify that dropping the @classmethod decorator on the result_validate_enum validator works as intended with your target Pydantic version and still executes the validation logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Regenerate the Python SDK after removing report builder support, update the OpenAPI spec to v2.8.0 and bump the client version to v3.1.0, and adjust linting configuration for Pydantic validators.
Enhancements:
Chores: