Update test cases to Modelica 4.0 and compilation toolchain#799
Open
EttoreZ wants to merge 110 commits into
Open
Update test cases to Modelica 4.0 and compilation toolchain#799EttoreZ wants to merge 110 commits into
EttoreZ wants to merge 110 commits into
Conversation
dhblum
reviewed
Apr 9, 2026
dhblum
reviewed
Apr 9, 2026
| @@ -1 +1 @@ | |||
| {"peak_heat_day": 23, "typical_heat_day": 115} | |||
| {"peak_heat_day": 27, "typical_heat_day": 58} No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Realizing do we need to update the days.json for all the models that had significant model changes? For example twozone_apartment_hydronic. I don't see changes in the PR for those. Will need to change days.json and documentation of scenarios.
dhblum
reviewed
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
@EttoreZ to change this model to use pre-configured mover model from Buildings 12.1.0.
…l_dimensions Issue834: multizone residential dimensions
…ffectiveness calculation
…BPSA weather reader
…boptest into issue422_om_msl4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to various issues #422, #539, #612, #775, #791, #800, #802, #806, and #834 is meant to:
Two Zone Apartment Hydronic, Multizone Residential Hydronic, Multizone Office Simple Air Modelica Models) cases to Modelica 4.0 and newer version of the libraries.
Below is reported a list to dos to finalize this PR:
Test cases update
compile_fmu.py,library_version.json, etc..).Compilation toolchain
Unit test update
Misc
compile_fmu.py toolargument inparser.export_fmu(tool)should be made into a input argument to allow flexibility in the makefile. Furthermore, optional argumentssolverandtoleranceshould be properly handled by the parser depending on the tool with warnings and errors.multizone_office_complex_airpoints tocompare_references.pyscript.