Skip to content

BX-11236: Use design-system button component#1838

Open
tischsoic wants to merge 234 commits into
6.0from
IBX-11236-use-ds-btn-component
Open

BX-11236: Use design-system button component#1838
tischsoic wants to merge 234 commits into
6.0from
IBX-11236-use-ds-btn-component

Conversation

@tischsoic
Copy link
Copy Markdown
Contributor

@tischsoic tischsoic commented Feb 26, 2026

🎫 Issue IBX-XXXXX

Description:

For QA:

Documentation:

@tischsoic tischsoic self-assigned this Feb 26, 2026
@barbaragr barbaragr mentioned this pull request Feb 26, 2026
Draft
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from 30c24df to 5c13474 Compare March 2, 2026 07:58
@barbaragr barbaragr mentioned this pull request Mar 2, 2026
Draft
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch 2 times, most recently from 69e583a to 2ccfc8f Compare March 8, 2026 22:07
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch 4 times, most recently from 7f4c061 to 7bbd081 Compare March 24, 2026 09:39
@tischsoic tischsoic changed the title Ibx 11236 use ds btn component BX-11236: Use design-system button component Apr 14, 2026
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from a3d4193 to 257bfa9 Compare April 22, 2026 09:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 23, 2026

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.5% Duplication on New Code

See analysis details on SonarQube Cloud

@ibexa-yuna ibexa-yuna deleted the branch 6.0 April 29, 2026 08:11
@ibexa-yuna ibexa-yuna closed this Apr 29, 2026
@mnocon mnocon reopened this Apr 29, 2026
@mnocon mnocon changed the base branch from main to 5.0 April 29, 2026 09:35
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from 7f15365 to 1c9dc5a Compare May 13, 2026 09:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 19, 2026

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud

albozek
albozek reviewed May 20, 2026
View reviewed changes
Comment thread src/bundle/Resources/public/js/scripts/admin.contenttype.relation.default.location.js
deleteBtn?.removeAttribute('disabled');
}

// Keep legacy 'disabled' class for backward compatibility with existing CSS
Copy link
Copy Markdown
Contributor

@albozek albozek May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for later: if at the end we decide to merge ds components to 6.0 not 5.0, we probably won’t need this

Comment thread src/bundle/Resources/views/themes/admin/account/login/index.html.twig
</button>
</twig:ibexa:button>
<div class="ibexa-login__link-wrapper">
<a href="{{ path('ibexa.user.forgot_password') }}" tabindex="4">{{ 'authentication.forgot_password'|trans|desc('Forgot your password?') }}</a>
Copy link
Copy Markdown
Contributor

@albozek albozek May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twig:ibexa:link ?

Copy link
Copy Markdown
Contributor Author

@tischsoic tischsoic May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been adding twig:ibexa:link to links which do not have any ibexa- css class.

Comment thread src/bundle/Resources/views/themes/admin/link_manager/view.html.twig
@@ -37,13 +37,15 @@
<td class="ibexa-table__cell">{{ 'url.label.address'|trans|desc('Address') }}</td>
<td class="ibexa-table__cell ibexa-table__cell--has-action-btns">
<a href="{{ url.url }}" target="_blank">{{ url.url }}</a>
Copy link
Copy Markdown
Contributor

@albozek albozek May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twig:ibexa:link ?

Copy link
Copy Markdown
Contributor Author

@tischsoic tischsoic May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been adding twig:ibexa:link to links which do not have any ibexa- css class.

Comment thread src/bundle/ui-dev/src/modules/sub-items/components/action-btn/action.btn.js
onClick={handleClick}
disabled={disabled}
title={title}
className={`c-action-btn${type ? ` c-action-btn--${type}` : ''}`}
Copy link
Copy Markdown
Contributor

@albozek albozek May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: maybe you could bring back createCssClassNames to silence sonar?

@tischsoic tischsoic changed the base branch from 5.0 to 6.0 June 1, 2026 07:49
tischsoic added 28 commits June 1, 2026 10:02
@tischsoic
fix: use DS classes in section assigned content button
efc1ed1
@tischsoic
fix: use DS classes in location swap button
a49f24f
@tischsoic
fix: use DS classes in context menu buttons
5f7a423
@tischsoic
fix: use DS classes in sidebar base buttons
3dfb97a
@tischsoic
fix: use DS classes in right sidebar buttons
97daf25
@tischsoic
fix: use DS classes in action list buttons
0d61f85
@tischsoic
fix: support DS button markup in context menu script
0ac9144
@tischsoic
fix: align DS modal close buttons
d852c02
@tischsoic
fix: hide adaptive filter fake DS toggler buttons
c9b3ddd
@tischsoic
fix: restore DS styling in account auth forms
a232bef
@tischsoic
fix: align DS button icon sizing
4cd43f9
@tischsoic
fix context menu adapive items classes
c40d863
@tischsoic
fix UDW
9bf16d9
@tischsoic
fix: finish segmentation DS button migration
42f998f
@tischsoic
fix: finish admin UI DS button migration
ef41de5
@tischsoic
fix: align admin UI hide button helper
f438da4
@tischsoic
fix: align admin UI draft edit button helper
0910711
@tischsoic
fix: remove admin UI legacy no-text DS mix
daf9de1
@tischsoic
fix: align admin UI UDW swap button helper
9f84e0a
@tischsoic
fix: align admin UI DS button labels
92d3a6c
@tischsoic
fix: align admin UI focus mode button label
2fccb40
@tischsoic
fix: use DS Button in admin UI language selector
08f6e58
@tischsoic
fix: use Twig button tags in admin UI macros
f3f2fa7
@tischsoic
style: remove redundant Twig button html_type attrs
5d8a43f
@tischsoic
fix: use Twig button tags in admin UI templates
e7847da
@tischsoic
style: fix Twig button tag indentation in admin UI templates
f829bc4
@tischsoic
remove TODOs
7355c9f
@tischsoic
fix: avoid double-escaping limitation value template
2fd6a84
@tischsoic tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from fd88a6c to 2fd6a84 Compare June 1, 2026 08:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albozek albozek albozek left review comments

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@tischsoic tischsoic

@dew326 dew326

@ViniTou ViniTou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tischsoic @albozek @mikadamczyk @ciastektk @mnocon @dew326 @ViniTou @ibexa-yuna