chore: sync master → development#222
Merged
Merged
Conversation
Release v2.0.0
The idempotent `gh api PUT /pages -F build_type=workflow` step was meant to self-heal the Pages source from the legacy `gh-pages` branch to `workflow` on the first run. It always returns 403 because the workflow's `GITHUB_TOKEN` — even with `pages: write` declared — can only DEPLOY via Pages (the `deploy-pages` action), not modify the Pages site settings, which is a repo-admin scope. Done manually instead: `gh api -X PUT repos/$REPO/pages -F build_type=workflow` from an admin-authed CLI. Comment added describing the one-time flip so it's visible next time someone reads the workflow. First docs.yml run on master failed at this step; removing it lets the rerun complete — Pages is already in workflow mode now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the post-release commits on `master` back into `development` so the two branches don't drift.
What's in here
The merge commit (`b53fe6b`) is a no-op re-merge of development's own history, so the only real change landing on development is the docs workflow fix above.
Why merge instead of cherry-pick
Keeps the release-tag history linear on development: `v2.0.0` points at `b53fe6b` which will be reachable from development after this merge, and future `git describe` on development will surface `v2.0.0` as the most recent stable tag.