Add prop keySeparator#186
Conversation
Introduce the option to split/join node paths by a char other than `/`.
| data={mockDataWithSlashes} | ||
| openNodes={['item2/a']} | ||
| keySeparator=";" |
There was a problem hiding this comment.
hi @PRGfx , thanks for the PR! It's indeed a useful prop!
Is it possible to make this test case more specific by setting openNodes to item2/a;b (and b needs nodes as well)? So that it can fully demonstrate the use case of this new prop 🙂
|
Hey, sorry for the delay, I don't really need this feature. I adjusted the test-case as you suggested. However |
|
Closing this as superseded by the v2 rewrite. The
Thanks for the original proposal and for flagging issue #162 — the design conversation here helped shape the final prop. Try the RC: ``` |
Introduce the option to split/join node paths by a character other than
/.It seems I had to go through the walk setup, which led to a lot of changes in the tests.
I'm not convinced about defining the default separator in two places, but I am not sure where best to define such "shared" value.
Resolves #162