Open
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||
|
Contributor
|
@NoB0 Can you please check if this is needed? |
Collaborator
|
@kbalog I think that this is still relevant and valuable class (we have a slightly different implementation in UserSimCRS). In my opinion, the dialogue state is part of the context that may influence decision making. Although, I would slight update the dataclass to be aligned with the notion of dialogue act and make |
Collaborator
Author
|
@NoB0 Will you take the lead on this one? You know better how it fits the current architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158