chore: Clean contracts and tests - part1#330
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs code cleanup and reorganization across contracts and tests. It moves shared base contracts to an abstract/ directory, standardizes naming conventions for npm scripts, and refactors test utilities by removing unnecessary helper functions. The changes maintain backward compatibility while improving code organization and maintainability.
Key Changes:
- Reorganized Solidity contracts by moving shared base contracts (IexecEscrow, IexecPocoCommon, SignatureVerifier) from
facets/toabstract/directory and marking them as abstract - Standardized npm script naming from
check-<action>to<action>:checkpattern - Refactored test utilities by inlining helper functions and updating imports
Reviewed changes
Copilot reviewed 17 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/byContract/IexecPocoBoost/IexecEscrow.test.ts | Updated test suite description from "IexecEscrow.v8" to "IexecEscrow" |
| test/byContract/IexecEscrow/IexecEscrowToken-receiveApproval.test.ts | Removed helper functions and inlined their calls; updated imports to use MatchOrdersFacetMock |
| package.json | Renamed scripts from check-format/check-doc to format:check/doc:check |
| hardhat.config.ts | Updated docgen exclusions to reference abstract/ directory instead of facets/ |
| contracts/tools/testing/MatchOrdersFacetMock.sol | Renamed from ReceiveApprovalTestHelper; simplified revert statement |
| contracts/facets/*.sol | Updated imports to reference abstract base contracts from ../abstract/ directory |
| contracts/abstract/*.sol | Marked SignatureVerifier and IexecPocoCommon as abstract contracts |
| .github/workflows/main.yml | Updated CI script calls to use new format:check and doc:check names |
| docs/solidity/index.md | Reordered IexecEscrow documentation section |
| docs/uml/*.svg | Auto-generated UML diagrams reflecting contract reorganization |
| abis/* | Auto-generated ABI files for newly exposed abstract contracts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 33 33
Lines 1134 1135 +1
Branches 228 228
=======================================
+ Hits 1093 1094 +1
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.