Skip to content

Reimplement Project Template#7

Open
Valkryst wants to merge 2 commits into
hyperskill:masterfrom
Valkryst:fix-issues
Open

Reimplement Project Template#7
Valkryst wants to merge 2 commits into
hyperskill:masterfrom
Valkryst:fix-issues

Conversation

@Valkryst
Copy link
Copy Markdown

@Valkryst Valkryst commented Nov 2, 2023

This PR fixes some minor annoyances that I ran into when starting the project on Hyperskill:

  • Updated ApplicationRunner to start the Swing application on the EDT.
  • Updated the constructor in WebCrawler to:
    • Add a title to the frame.
    • Remove setLayout(null) as it seemed to serve no purpose.
    • Swap setSize for setPreferredSize.
    • Update all superclass calls to explicitly use super. for clarity.
    • Update the order of operations to ensure the frame is centered on the screen when started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant