REPL - stage 2#5
Open
Miffka wants to merge 10 commits into
Open
Conversation
swsms
reviewed
Oct 8, 2018
Contributor
swsms
left a comment
swsms
left a comment
There was a problem hiding this comment.
Good solution! Congratulations!
| } | ||
|
|
||
| public static boolean answerToServiceCommand(String input){ | ||
| boolean stop_iteration = false; |
Contributor
There was a problem hiding this comment.
This name looks like a Python variable rather than Java (underscode instead of camelCase notation).
| String[] numbers_and_operators = input.split("\\s+"); | ||
| int ans = 0; | ||
| int number = 0; | ||
| int n_minuses = 0; |
| System.out.println(ans); | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
Contributor
There was a problem hiding this comment.
Your solution looks pretty good! But it is not very good idea to add Main.class and out directory to GitHub.
denderov
added a commit
to denderov/repl
that referenced
this pull request
Mar 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main.java, Main.class as well as idea settings added.