Support exponent numbers an efficiency improvements for Hex int parsing#102
Merged
Conversation
…sing Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
onelapahead
approved these changes
Jun 23, 2026
EnriqueL8
approved these changes
Jun 23, 2026
| *h = HexInteger{} // zero big.Int has nil abs — no allocation | ||
| return nil | ||
| case c >= '1' && c <= '9': | ||
| *h = HexInteger(*big.NewInt(int64(c - '0'))) |
Contributor
There was a problem hiding this comment.
ah this is cleaver stuff the c - '0' to convert a byte to numeric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing
HexIntegeris hot code in JSON/RPC interactions, and very often there are very small numbers - particularly zero.Flame graph analysis shows we spend quite a lot of compute on allocating and parsing integers for these cases, so it's worth a low level optimization for the trivial cases.
Also I observed we were using big.Float parsing which doesn't handle exponent notation like 1e10, which is valid in JSON.