chore: upgrade to Go 1.26.4#222
Merged
Merged
Conversation
EnriqueL8
reviewed
Jun 26, 2026
| module github.com/hyperledger-firefly/common | ||
|
|
||
| go 1.23.0 | ||
| go 1.26.0 |
Contributor
There was a problem hiding this comment.
latest is 1.26.4 - can you upgrade to that please
Signed-off-by: Daniel Raper <daniel.raper@kaleido.io>
dan-r
force-pushed
the
chore/upgrade-go-1.26
branch
from
056f5ac to
9ed41dd
Compare
EnriqueL8
approved these changes
Jun 26, 2026
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
We need to put in the release notes that this completely breaking and that if anyone upgrade to the new version of common they will break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates common to Go 1.26.4.
go.modgo directive1.23.0→1.26.4go-version1.23→1.26.4vetnow rejects (pkg/fswatcher/fswatcher_test.go,pkg/i18n/errors_test.go)golangci-lint (v1.64.8) and all tests pass on Go 1.26.4. Note: bumping the module
godirective requires downstream consumers ofhyperledger-firefly/commonto build with Go 1.26.4+.