Future build: Updated workflows and builds#1966
Open
Suika wants to merge 22 commits intohydrusnetwork:masterfrom
Open
Future build: Updated workflows and builds#1966Suika wants to merge 22 commits intohydrusnetwork:masterfrom
Suika wants to merge 22 commits intohydrusnetwork:masterfrom
Conversation
Use contents_directory to create cleaner builds as well as consolidating the build specs for the server and client into one spec. Files are moved via the spec.
Use contents_directory to create cleaner builds as well as consolidating the build specs for the server and client into one spec.
In general it is not advised to remove any .so files from pyinstaller builds.
--no-same-owner
Extract files as yourself (default for ordinary users).
--no-same-permissions
Apply the user's umask when extracting permissions from the
archive (default for ordinary users).
-p, --preserve-permissions, --same-permissions
Set permissions of extracted files to those recorded in the
archive (default for superuser).
--same-owner
Try extracting files with the same ownership as exists in
the archive (default for superuser).
gha does not cache anything. And this should live longer than then gha cache either way.
Owner
|
Thank you again! I hope to fold this into a 'future build' test for v661 and will merge this into a new branch probably next Saturday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
For this pull to work it needs something like bellow, or better yet https://pyinstaller.org/en/stable/runtime-information.html with __file__ usage, since it will either point to _MEIPASS or the .py file being executed. I see some old logic in the code, but it is kinda twisted: