Fix: resolve AICPU View overlapping bars and misbound flow arrows in swimlane#557
Merged
poursoul merged 1 commit intohw-native-sys:mainfrom Apr 15, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the swimlane_converter.py tool to support overlapping tasks on the same core within the AICPU View. It introduces a greedy lane assignment algorithm that maps concurrent tasks to distinct thread IDs (TIDs), ensuring Perfetto renders them on separate rows. Additionally, the PR updates dependency and dispatch flow events to use these specific TIDs and includes bind_id metadata for better event linking. Feedback was provided regarding the efficiency of the metadata generation loop and the need for more robust handling of multiple sub-lanes beyond the hardcoded dual-slot assumption.
…swimlane Perfetto silently drops partially overlapping slices on the same tid and binds flow-finish events to the wrong enclosing slice when bars overlap. - Assign per-core AICPU tids as 10000 + core_id * 10, with greedy lane assignment placing overlapping tasks on base_tid + 1 (dual-slot overflow) - Add bind_id to AICPU dependency and scheduler→task flow events so arrows attach to the correct slice regardless of overlap - Generate AICPU View thread metadata independently (not inside AICore loop) since overflow lanes need separate entries
indigo1973
force-pushed
the
prof_0414_v2
branch
from
1d19375 to
fcc2fff
Compare
poursoul
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfetto silently drops partially overlapping slices on the same tid and binds flow-finish events to the wrong enclosing slice when bars overlap.