Feat: enhance golden validation error output with mismatch details#550
Merged
ChaoWao merged 1 commit intohw-native-sys:mainfrom Apr 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the error reporting in the tensor comparison utility by including specific details for the first 20 mismatched elements in the AssertionError message. The feedback identifies an opportunity to optimize the string construction using vectorized indexing and list conversion to avoid the performance overhead of repeated .item() calls, while also noting a redundancy in the mismatch count calculation.
- Add detailed mismatch information to golden validation error messages - Show first 20 mismatched elements with indices and actual/expected values - Use vectorized operations for better performance - Improve debugging experience for test failures
sjduan
force-pushed
the
feat/enhance-golden-error-details
branch
from
d014989 to
bcf2617
Compare
ChaoWao
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing