Skip to content

ci: cache ptoas binary and extract version to env var#799

Closed
luohuan19 wants to merge 1 commit intohw-native-sys:mainfrom
luohuan19:ci-opt
Closed

ci: cache ptoas binary and extract version to env var#799
luohuan19 wants to merge 1 commit intohw-native-sys:mainfrom
luohuan19:ci-opt

Conversation

@luohuan19
Copy link
Copy Markdown
Contributor

  • Add actions/cache@v4 step to cache the ptoas binary keyed by version and architecture, skipping download on cache hit
  • Extract PTOAS_VERSION to a job-level env var (was inline in the install script) to serve as the cache key
  • Rename "Clone and install simpler repository (pinned)" step label to "(stable)" to match the actual branch name being cloned

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4be86c7f-d7df-42e4-9517-5ae815cdd88a

📥 Commits

Reviewing files that changed from the base of the PR and between aeab322 and 784ad18.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

CI workflow updated to add a PTOAS version env var, cache the ptoas binary, conditionally skip installation on cache hit, and rename "simpler" clone/install step labels from "(pinned)" to "(stable)".

Changes

Cohort / File(s) Summary
PTOAS Binary Caching
​.github/workflows/ci.yml
Added PTOAS_VERSION: v0.16 to job env, introduced actions/cache@v4 step caching ${{ github.workspace }}/ptoas-bin with a version/arch key, and made the Install ptoas step run only when cache miss occurs.
Simpler Repository Step Labels
​.github/workflows/ci.yml
Changed step labels for Clone/install simpler in system-tests and fuzz-tests-sim from "(pinned)" to "(stable)" (checkout command remains --branch stable --depth 1).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • lyfne123

Poem

🐰 I cached the ptoas, snug in a bin,
Stable branches hum, no pins to spin,
Steps skip and dance when the cache sings true,
CI hops along — a quick carrot for you! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: caching the ptoas binary and extracting PTOAS_VERSION to an environment variable, which are the primary improvements in this CI workflow optimization.
Description check ✅ Passed The description is directly related to the changeset, providing clear details about caching the ptoas binary, extracting the version to an env var, and renaming step labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Add `actions/cache@v4` step to cache the ptoas binary keyed by
  version and architecture, skipping download on cache hit
- Extract PTOAS_VERSION to a job-level env var (was inline in the
  install script) to serve as the cache key
- Rename "Clone and install simpler repository (pinned)" step label
  to "(stable)" to match the actual branch name being cloned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants