Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request performs minor refactoring and cleanup across several test files. Key changes include reordering imports in Python tests, adding explanatory comments for NPU backend registration, and updating template arguments in C++ coverage tests to use explicit enum values. Additionally, the test script was updated with a try-finally block to ensure temporary files are deleted after execution. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op_extensionside-effect import to match Python import grouping in the baseline auto-mode add testtorch_npuside-effect import in the torch-jit add demo*_gen_data.pyhelper scripts intests/script/all_cpu_tests.pyviatry/finallytisa_coverageto use the currentTHISTOGRAM<HistByte::...>wrapper so the full CPU ST build passes againWhy
These are follow-ups from review comments on merged PRs #54, #55, and #57. While validating the cleanup change, the full CPU ST build also exposed a current-main compatibility break in
tisa_coverageafter theTHISTOGRAMwrapper moved frombooltemplate parameters toHistByte.Validation
python3 -m py_compile demos/auto_mode/baseline/add/test/test.py demos/auto_mode/torch_jit/add/add_compile_and_run.py tests/script/all_cpu_tests.pyruff check demos/auto_mode/baseline/add/test/test.py demos/auto_mode/torch_jit/add/add_compile_and_run.py tests/script/all_cpu_tests.pypython3 tests/script/all_cpu_tests.py -g Ninja -b build/cpu_review_followups