[codex] Add runtime resource overrides#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the third runtime-DI slice for Issue 45.0.
It introduces declared runtime resources on top of the existing
ExecutionOverrideswork for materializers and observers.What changed
resources={...}topipeline(...)/PipelineDefDagcontract asdag.resourcesResourceRegistrytoExecutionOverridesExecutionOverrides.resourcesWhy
The design already split runtime override into three families:
Materializers and observers were already implemented. The main missing piece was runtime-only dependencies such as database handles, API clients, or service objects that should not live in
paramsand should not require monkeypatching.This PR adds that missing contract explicitly.
Contract boundary
This PR keeps the intended boundary explicit:
ExecutionOverrides.resourcesExample
Impact
Pipelines can now declare runtime service dependencies explicitly, validate them at build time, and inject concrete fakes/mocks in tests without smuggling them through
paramsor rebuilding alternative pipeline definitions.This closes the three-registry shape described in the design doc, even though there is still follow-up work to polish docs and naming (
resourcesvsservices).Validation
uv run pytest