Make 'Select File' label translatable#340
Open
barryceelen wants to merge 6 commits intohumanmade:developfrom
Open
Make 'Select File' label translatable#340barryceelen wants to merge 6 commits intohumanmade:developfrom
barryceelen wants to merge 6 commits intohumanmade:developfrom
Conversation
Contributor
|
@barryceelen I like this and I'm glad we're moving towards more complete translatability! Could you also add a string to the Image field below the file one and straighten out the fatty arrows around line 430 & 516? Should only need to add Thank you! |
barryceelen
force-pushed
the
file-field-string
branch
from
c0d0205 to
faa7291
Compare
Contributor
Author
|
Okidoki that’s done. |
Contributor
Author
|
@mikeselander Merge conflicts fixed. |
Contributor
Author
|
@mikeselander Merged latest changes from develop. |
Contributor
Author
|
@mikeselander These little untranslated strings (and these) stand out like a sore thumb between their otherwise impeccably translated brethren 😢. Can we put them out of their misery 😉? |
Contributor
|
Hey @barryceelen sorry for taking so long! I'll do this next week :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To the detriment of global fraternisation the ‘Select File’ media view title in
file-upload.jsremained untranslatable.