Fix MSRV badge showing "unknown"#27
Closed
akesson wants to merge 1 commit into
Closed
Conversation
The shields `crates/msrv/fluent-typed` endpoint reads the MSRV from the latest *published* crate, which is still 0.6.2 — it predates the `rust-version = "1.88"` field (added in the unreleased 0.7.0), so the badge rendered "unknown". Switch to a static MSRV badge that reflects the repo's actual minimum (1.88), matching `Cargo.toml`'s `rust-version` and the MSRV CI job. Bump the number alongside those if it ever changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
msrvbadge rendered "unknown" becauseimg.shields.io/crates/msrv/fluent-typedreads the MSRV from the latest published crate (still 0.6.2), which predates therust-version = "1.88"field added in the unreleased 0.7.0.Switched to a static badge (
MSRV 1.88) that reflects the repo's actual minimum and matchesCargo.toml'srust-versionand the MSRV CI job. Bump the number alongside those if the MSRV ever changes.(The dynamic
crates/msrvbadge would start working once 0.7.0 is published, but a static badge avoids the "unknown" window and always tracks the repo rather than the last release.)🤖 Generated with Claude Code