Skip to content

fix resizing for three.js r88 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixturner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix resizing for three.js r88 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
var camera, scene, renderer, composer;
var object, light;
var dsEffect;

var THREE = require('three')
, EffectComposer = require('./')(THREE)
Expand Down Expand Up @@ -72,6 +73,8 @@ THREE.RGBShiftShader = {
].join("\n")
};



init();
animate();

Expand All @@ -91,7 +94,7 @@ function init() {
scene.add( object );

var geometry = new THREE.SphereGeometry( 1, 4, 4 );
var material = new THREE.MeshPhongMaterial( { color: 0xffffff, shading: THREE.FlatShading } );
var material = new THREE.MeshPhongMaterial( { color: 0xffffff, flatShading: true } );

for ( var i = 0; i < 100; i ++ ) {

Expand All @@ -115,27 +118,32 @@ function init() {
composer = new EffectComposer( renderer );
composer.addPass( new EffectComposer.RenderPass( scene, camera ) );

var effect = new EffectComposer.ShaderPass( THREE.DotScreenShader );
effect.uniforms[ 'scale' ].value = 4;
composer.addPass( effect );
dsEffect = new EffectComposer.ShaderPass( THREE.DotScreenShader );
composer.addPass( dsEffect );

var effect = new EffectComposer.ShaderPass( THREE.RGBShiftShader );
effect.uniforms[ 'amount' ].value = 0.0015;
effect.renderToScreen = true;
composer.addPass( effect );

//

window.addEventListener( 'resize', onWindowResize, false );
onWindowResize();

}

function onWindowResize() {

camera.aspect = window.innerWidth / window.innerHeight;
var w = window.innerWidth;
var h = window.innerHeight;

camera.aspect = w / h;
camera.updateProjectionMatrix();

renderer.setSize( window.innerWidth, window.innerHeight );
renderer.setSize( w, h );
composer.setSize( w, h );

//some passes need screen resolution passed in
dsEffect.uniforms.tSize.value = new THREE.Vector2(w,h);

}

Expand Down
8 changes: 2 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,8 @@ module.exports = function(THREE) {

setSize: function ( width, height ) {

var renderTarget = this.renderTarget1.clone();

renderTarget.width = width;
renderTarget.height = height;

this.reset( renderTarget );
this.renderTarget1.setSize( width, height );
this.renderTarget2.setSize( width, height );

}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"three-copyshader": "0.0.1"
},
"devDependencies": {
"three": "~0.55.0",
"three": "~0.88.0",
"browserify": "*"
},
"repository": {
Expand Down