This repository was archived by the owner on Apr 6, 2026. It is now read-only.
misc(cmake): rely on the more robust Python3 module to handle Python detection#238
Merged
Conversation
mfuntowicz
changed the title
MekkCyber
approved these changes
Oct 1, 2025
MekkCyber
left a comment
MekkCyber
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update lgtm
danieldk
reviewed
Oct 1, 2025
danieldk
left a comment
danieldk
left a comment
Member
There was a problem hiding this comment.
Rebasing on main should make the tests work.
mfuntowicz
force-pushed
the
cmake-python3
branch
from
b569533 to
4384f73
Compare
danieldk
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would make use of the Python3 cmake module in-place of Python as we are not targeting Python2