ci: fold e2e jobs into one matrix (e2e-forgejo-15 / e2e-gitea-1.22 / e2e-plane-1.3)#17
Merged
Conversation
Cosmetic: e2e-docker and e2e-real-plane were two separate jobs with
divergent naming. Merge into a single e2e job with a 3-entry matrix
named forgejo-15 / gitea-1.22 / plane-1.3, so all three legs line up
in the GitHub Actions UI under a consistent e2e-* prefix.
Mechanics: flattened matrix.forge.{name,image,flavor} to
matrix.{name,forge_image,flavor}. Forge-specific steps gain
if: matrix.flavor != 'plane'; plane-specific steps gain
if: matrix.flavor == 'plane'. Diagnostics + cleanup are flavor-aware
inline. The forge service container starts unconditionally (GHA
services: can't be conditional per matrix entry) but the plane leg's
bridge config points at http://forge.invalid so the container is never
reached.
publish now depends on `e2e` (the whole matrix) instead of separate
e2e-docker + e2e-real-plane needs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cosmetic: merge the two separate
e2e-dockerande2e-real-planejobs into a singlee2ejob with a 3-entry matrix. Job names line up in the UI ase2e-forgejo-15,e2e-gitea-1.22,e2e-plane-1.3.What changed
matrix.forge.{name,image,flavor}→matrix.{name,forge_image,flavor}(flattened)if: matrix.flavor != 'plane'if: matrix.flavor == 'plane'publishnow needs the unifiede2ejob (single dependency)Quirk
GHA
services:can't be conditionally defined per matrix entry — every entry must specify a service image. The plane leg setsforge_image: codeberg.org/forgejo/forgejo:15(reusing the forgejo-15 leg's cached layer) so the service container starts, but the plane leg's bridge config points athttp://forge.invalidso it's never reached. ~5s of wasted boot time per plane run; negligible relative to the ~90s Plane CE cold-cache boot.No code change
This only touches
.github/workflows/ci.yaml+ a README sentence. No version bump.🤖 Generated with Claude Code