feat: add Marshall CV-370 day/night toggle#2
Conversation
hrueger
left a comment
There was a problem hiding this comment.
Please change the following things:
- make this more modular (there should be only one MarshallCV370 file providing logic and controls, but no cv370 logic in the main app files). So that it is easy to add support for more / different cams without ending up with thousands of properties in StreamSourcePanel for example...
- Can you detect whether it is a CV370 by getting the IP from the NDI Stream?
|
Implemented the requested changes:
Verified locally:
Note: full Linux app link is not representative here because this environment lacks the real NDI/DNS-SD platform libraries; the focused tests pass. |
hrueger
left a comment
There was a problem hiding this comment.
Much better, but the Camera control should be an extra panel. Allow user to input a custom host/ip for example if that does not match with ndi or using a different stream.
In addition: some widgets are too wide, they cause horizontal scrolling. This should not be the case. All other widgets in the other panels dont cause scroll but shrink.
See this photo:
|
Addressed the latest review feedback:
Verification:
|
|
Superseded by #4, recreated from the upstream hrueger/onpoint branch so GitHub Actions run in the repository context. |
Summary
ircut: 1for daylight,ircut: 0for night).Closes #1
Test Plan
cmake -S . -B build-test -DBUILD_TESTING=ONwith a local stub NDI SDKcmake --build build-test --target onpoint_tests --parallelctest --test-dir build-test --output-on-failureNote: a full Linux
onpointtarget build currently reaches an existing platform gap unrelated to this change:DnsSdBridgehas macOS/Windows implementations, but no Linux implementation is linked by CMake.