fix: rewrite for memory efficiency#23
Open
Jaarabytes wants to merge 1 commit into
Open
Conversation
Owner
|
oh shit we have a pr lmao |
horahoradev
reviewed
Nov 25, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| defer func() { |
Author
There was a problem hiding this comment.
Hello, just realized that they are redundant and unnecessary.
I should have rewritten to (since the code is closing the video and thumb files which have just been opened):
defer thumbFile.Close()
defer videoFile.Close()
Owner
|
looks fine to me tbh, just not sure about the initial defers |
Author
|
Heyy, you can get rid of them/rewrite them Also, sorry for the late reply (was on long vacation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite Upload func to reuse the same buffer chunk (using defer and Close) increasing memory efficiency
Add maxThumbnailSize; (you can customize to whichever value you see fit)