Adding SMOKE_DETECTOR, ACCESS_POINT, SHUTTER_CONTACT, DOOR_LOCK_DRIVE & missing JSON type definitions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Adding some JSON objects for |
Bizarrus
changed the title
Author
|
Adding some missing
|
Bizarrus
changed the title
Bizarrus
commented
Jan 27, 2026
| SMOKE_ALARM(Set.of(Feature.SMOKE_ALARM), Set.of(Feature.MAINTENANCE)), | ||
|
|
||
| @TypeValueDocumentation(description = "Type for smoke detecting devices.") | ||
| SMOKE_DETECTOR(Set.of(Feature.SMOKE_ALARM), Set.of(Feature.MAINTENANCE)), |
Author
There was a problem hiding this comment.
You can support Java 8 fully, if you replace single Set.of's with Collections.singleton and lists with new HashSet<>(Arrays.asList(<entries>)):
Before
@TypeValueDocumentation(description = "Type for door locks.")
DOOR_LOCK_DRIVE(Set.of(Feature.SWITCH_STATE),Set.of(Feature.MAINTENANCE, Feature.CONTACT_SENSOR_STATE)),After
@TypeValueDocumentation(description = "Type for door locks.")
DOOR_LOCK_DRIVE(Collections.singleton(Feature.SWITCH_STATE), new HashSet<>(Arrays.asList(Feature.MAINTENANCE, Feature.CONTACT_SENSOR_STATE))),I don't understand why minimum compatibility with Java 11 is required just because of this class. Without Set.of, everything would be completely backward compatible and other use cases would be covered.
Take a look at my java-8 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #6