Add more suspension logs#149
Open
supersuryaansh wants to merge 4 commits into
Open
Conversation
|
|
||
| async suspend({ log = noop } = {}) { | ||
| await log('Flushing db...') | ||
| await log('Corestore suspension started...') |
There was a problem hiding this comment.
nit:
if we return quickly if !shouldSuspend is true, then suspension did not really start.
Also is Corestore prefix needed here?.
I would argue
"
Suspension requested...
"
is a better first log
Member
Author
There was a problem hiding this comment.
Fixed the rest, nice to have the corestore prefix as we have this suspension happening in a lot of places in the stack
| await log('Corestore suspension started...') | ||
| // If readOnly we don't need to flush | ||
| if (!this.storage.readOnly) { | ||
| await log('Flusing db...') |
| if (!this.storage.readOnly) { | ||
| await log('Flusing db...') | ||
| await this.storage.db.flush() | ||
| await log('Flusing db completed') |
marcus-pousette-hp
previously approved these changes
Jun 25, 2026
mafintosh
previously approved these changes
Jun 25, 2026
supersuryaansh
dismissed stale reviews from mafintosh and marcus-pousette-hp
via
af25abf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.