Fix StoreTimer start point and async path labeling#377
Merged
hlin99 merged 2 commits intoJun 18, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix StoreTimer placement issues in async_data.py and gpu_transfer.py
Fix StoreTimer start point and async path labeling
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts multiprocess store timing so
submit_store()measures from the caller-visible entry point, and removes an invalid async GPU timing mark that was being emitted without waiting for device completion.Start timing at
submit_store()entryAsyncDataTransferContext.submit_store()now createsStoreTimerimmediately after the registration check, beforeprepare_store()and buffer allocation._t0reflect the latency seen by the caller, rather than starting partway through the store path.Support deferred path resolution
StoreTimer.set_path()so the timer can be created early and labeled later once the transfer mode is known.async_data.pynow starts with a generic path and updates it toshmorpickleafterused_shm_directis determined.Remove meaningless async GPU mark
timer.mark("kv_releasable")from the async GPU IPC store path ingpu_transfer.py.Example